Add TopCP CI container build #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: Add lock file for uproot image * Add lock.sh script that uses uv to build a hash level lock file from a high level requirements.txt file. * Use lock.sh to build a lock file and add the requirements.lock lock file. * Build the Dockerfile using the environment defined in requirements.lock. * make lock.sh executable * Small documentation for uproot --------- Co-authored-by: Peter Onyisi <[email protected]> Co-authored-by: ponyisi <[email protected]>
… the OSG certificates (#12)
New science image.
* Update atlas.yaml for latest R21 and 22 releases * Update build_r21.sh * Update build_r22.sh * Update README.md
There was a problem hiding this comment.
Pull Request Overview
This PR adds new CI workflows and documentation to support building container images for Uproot, TopCPToolkit, and ATLAS.
- Introduces a new GitHub workflow for building the Uproot image nightly.
- Adds documentation and a workflow for building the TopCPToolkit science image.
- Updates the main README and the Atlas workflow with new build configurations.
Reviewed Changes
Copilot reviewed 7 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| uproot/README.md | Adds documentation for the Uproot science image and package versioning. |
| TopCP/README.md | Provides build instructions for the TopCP container image. |
| README.md | Updates overall project documentation to include new build details. |
| .github/workflows/uproot-nightly.yaml | Introduces a nightly workflow to build the Uproot image for certificate checks. |
| .github/workflows/topcp.yaml | Adds a CI workflow for building the TopCPToolkit science image. |
| .github/workflows/atlas.yaml | Updates the Atlas image build jobs with new version tags and build arguments. |
Files not reviewed (10)
- ATLASxAOD/Dockerfile: Language not supported
- ATLASxAOD/build_r21.sh: Language not supported
- ATLASxAOD/build_r22.sh: Language not supported
- ATLASxAOD/build_r25.sh: Language not supported
- TopCP/Dockerfile: Language not supported
- TopCP/boot.bash_profile: Language not supported
- TopCP/boot.sh: Language not supported
- uproot/Dockerfile: Language not supported
- uproot/lock.sh: Language not supported
- uproot/requirements.txt: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/topcp.yaml:33
- [nitpick] Consider reviewing the secret naming; the README and workflow both refer to 'GIT_KEY', so using a secret named GITLAB_TOKEN may cause confusion. If different names are intentional, a clarifying comment would help.
GIT_KEY=${{ secrets.GITLAB_TOKEN }}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an action to build the container