-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test/integration/rework #1607
Test/integration/rework #1607
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1607 +/- ##
===========================================
- Coverage 88.08% 87.87% -0.22%
===========================================
Files 36 35 -1
Lines 2509 2465 -44
===========================================
- Hits 2210 2166 -44
Misses 255 255
Partials 44 44 ☔ View full report in Codecov by Sentry. |
7534717
to
7362cef
Compare
536ccf6
to
a72c827
Compare
a72c827
to
243ba09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I like the restructuring. Added a few more comments, mainly wrt to bash settings and making user-system controlled variables that may contain spaces be a single word in commands
The bigger comment from before that this doesn't allow me to just run a single command to fully test the setup, e.g. something like an 'all', is still not addressed. Wouldn't the previous run_integration_test script not work equally well with the modularized tests?
d4ce578
to
47adccf
Compare
test/integration/self-hosted-notary/notary-service-container/server/notary-server.key
Outdated
Show resolved
Hide resolved
test/integration/self-hosted-notary/notary-service-container/signer/ca.crt
Outdated
Show resolved
Hide resolved
test/integration/self-hosted-notary/notary-service-container/signer/notary-signer.crt
Outdated
Show resolved
Hide resolved
test/integration/self-hosted-notary/notary-service-container/signer/notary-signer.key
Outdated
Show resolved
Hide resolved
test/integration/self-hosted-notary/notary-service-container/signer/config.json
Outdated
Show resolved
Hide resolved
Restructure integration tests to be more modular and maintainable.
0fd0cfd
to
c18b6dd
Compare
Rework of integration tests
Checklist
develop
Chart.yaml
(if necessary)