Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/integration/rework #1607

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Test/integration/rework #1607

merged 1 commit into from
Jul 5, 2024

Conversation

phbelitz
Copy link
Member

@phbelitz phbelitz commented May 10, 2024

Rework of integration tests

Checklist

  • PR is rebased to/aimed at branch develop
  • PR follows Contributing Guide
  • Added tests (if necessary)
  • Extended README/Documentation (if necessary)
  • Adjusted versions of image and Helm chart in Chart.yaml (if necessary)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.87%. Comparing base (1562cd9) to head (a7c43ed).
Report is 6 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1607      +/-   ##
===========================================
- Coverage    88.08%   87.87%   -0.22%     
===========================================
  Files           36       35       -1     
  Lines         2509     2465      -44     
===========================================
- Hits          2210     2166      -44     
  Misses         255      255              
  Partials        44       44              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/integration/alerting/Dockerfile Dismissed Show dismissed Hide dismissed
test/integration/alerting/Dockerfile Dismissed Show dismissed Hide dismissed
Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
charts/connaisseur/values.yaml Show resolved Hide resolved
test/integration/README.md Outdated Show resolved Hide resolved
test/integration/README.md Outdated Show resolved Hide resolved
test/integration/pre-config/cases.yaml Outdated Show resolved Hide resolved
test/integration/regular/cases.yaml Outdated Show resolved Hide resolved
test/integration/workload/test.sh Outdated Show resolved Hide resolved
test/integration/common_functions.sh Show resolved Hide resolved
test/integration/main.sh Show resolved Hide resolved
@phbelitz phbelitz mentioned this pull request May 24, 2024
5 tasks
Copy link
Member

@Starkteetje Starkteetje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I like the restructuring. Added a few more comments, mainly wrt to bash settings and making user-system controlled variables that may contain spaces be a single word in commands

The bigger comment from before that this doesn't allow me to just run a single command to fully test the setup, e.g. something like an 'all', is still not addressed. Wouldn't the previous run_integration_test script not work equally well with the modularized tests?

test/integration/README.md Show resolved Hide resolved
test/integration/alerting/test.sh Outdated Show resolved Hide resolved
test/integration/alerting/test.sh Outdated Show resolved Hide resolved
test/integration/alerting/cases.yaml Outdated Show resolved Hide resolved
test/integration/cert/test.sh Show resolved Hide resolved
test/integration/main.sh Outdated Show resolved Hide resolved
test/integration/selfhosted-notary/test.sh Outdated Show resolved Hide resolved
test/integration/selfhosted-notary/test.sh Outdated Show resolved Hide resolved
test/integration/selfhosted-notary/test.sh Outdated Show resolved Hide resolved
test/integration/workload/test.sh Show resolved Hide resolved
@phbelitz phbelitz requested a review from Starkteetje July 5, 2024 10:16
Restructure integration tests to be more modular and maintainable.
@phbelitz phbelitz merged commit c18b6dd into develop Jul 5, 2024
51 checks passed
@phbelitz phbelitz deleted the test/integration/rework branch July 5, 2024 11:54
@phbelitz phbelitz mentioned this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants