-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
301 e2e increase coverage #310
base: main
Are you sure you want to change the base?
Conversation
…ldren as an admin, and that it appears when adding a child. Slightly refactor to add utils for E2E
…ake tests that use forms work with a little easier access to actual html objects using for tags for inputs.
… milestone score on the UI also actually updates, pretty neat! * Update the user properties so we have probably access to admin dashboard for our admin user
…wers for 7 children
…lestone answers so that we can test the feedback & stats page.
…one answering sessions, on the feedback page you see the achieved milestone group with a checkmark and named
…ly to revert this commit)
…ests that milestone feedback actually displays on the frontend etc.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #310 +/- ##
==========================================
+ Coverage 24.51% 26.04% +1.52%
==========================================
Files 126 127 +1
Lines 5924 6033 +109
Branches 111 112 +1
==========================================
+ Hits 1452 1571 +119
- Misses 4377 4450 +73
+ Partials 95 12 -83 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ores so that statistics show up and statistics tests can be ran e2e! (calculated from the previously inserted milestone answers). Revert scores.py to prior functionality/lack of print statements.
Ok a really important note: The E2E tests that deal with needing to have done the stats process need to tread differently. Because we can reasonably expect that normally, the user will be seeing data that has been fully processed by the stats. But for the E2E tests, there is nothing that calls the stats code before each test. Thus basically, fake milestoneanswerscores etc need to be put in accounting for each milestoneanswersession you put it. An additional .sql file has been created for this purpose which runs in the CI to import these derived parts of the milestone scores. It's separate because we want to be able to regenerate them and easily replace them if we change content in the second "importMilestoneAnswers.sql" file by changing/adding answers. |
… SQL load commands which take time to execute.
for more information, see https://pre-commit.ci
…to navigate to those pages (as a user would).
|
(Not ready for review)
Draft Pull request to trigger CCI and see if the new plain text SQL can indeed by loaded into the CI this way (rather than altering .db file which could become unwieldy and is just bytes in terms of diffs, so we have no easy record to look up what data should exist in the DB besides connecting to it when it is on your file system)