Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

301 e2e increase coverage #310

Draft
wants to merge 27 commits into
base: main
Choose a base branch
from
Draft

301 e2e increase coverage #310

wants to merge 27 commits into from

Conversation

jmsssc
Copy link
Collaborator

@jmsssc jmsssc commented Apr 7, 2025

(Not ready for review)

Draft Pull request to trigger CCI and see if the new plain text SQL can indeed by loaded into the CI this way (rather than altering .db file which could become unwieldy and is just bytes in terms of diffs, so we have no easy record to look up what data should exist in the DB besides connecting to it when it is on your file system)

jmsssc added 17 commits April 4, 2025 11:45
…ldren as an admin, and that it appears when adding a child. Slightly refactor to add utils for E2E
…ake tests that use forms work with a little easier access to actual html objects using for tags for inputs.
… milestone score on the UI also actually updates, pretty neat!

* Update the user properties so we have probably access to admin dashboard for our admin user
…lestone answers so that we can test the feedback & stats page.
…one answering sessions, on the feedback page you see the achieved milestone group with a checkmark and named
…ests that milestone feedback actually displays on the frontend etc.
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 26.04%. Comparing base (b495b6d) to head (06655c1).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
frontend/tailwind.config.ts 0.00% 4 Missing ⚠️
...src/routes/userLand/children/feedback/+page.svelte 0.00% 3 Missing ⚠️
.../src/lib/components/Admin/EditQuestionModal.svelte 0.00% 1 Missing ⚠️
...tend/src/lib/components/DataInput/DataInput.svelte 0.00% 1 Missing ⚠️
frontend/src/routes/+layout.svelte 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #310      +/-   ##
==========================================
+ Coverage   24.51%   26.04%   +1.52%     
==========================================
  Files         126      127       +1     
  Lines        5924     6033     +109     
  Branches      111      112       +1     
==========================================
+ Hits         1452     1571     +119     
- Misses       4377     4450      +73     
+ Partials       95       12      -83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jmsssc added 3 commits April 8, 2025 11:44
…ores so that statistics show up and statistics tests can be ran e2e! (calculated from the previously inserted milestone answers). Revert scores.py to prior functionality/lack of print statements.
@jmsssc
Copy link
Collaborator Author

jmsssc commented Apr 9, 2025

Ok a really important note:

The E2E tests that deal with needing to have done the stats process need to tread differently.

Because we can reasonably expect that normally, the user will be seeing data that has been fully processed by the stats.

But for the E2E tests, there is nothing that calls the stats code before each test.

Thus basically, fake milestoneanswerscores etc need to be put in accounting for each milestoneanswersession you put it.

An additional .sql file has been created for this purpose which runs in the CI to import these derived parts of the milestone scores. It's separate because we want to be able to regenerate them and easily replace them if we change content in the second "importMilestoneAnswers.sql" file by changing/adding answers.

@jmsssc
Copy link
Collaborator Author

jmsssc commented Apr 11, 2025

The mobile tests do not work because the code often makes calls to click on "Administration" in the side panel, however, the mobile version needs really to pop up the menu first to show that option:

image

…to navigate to those pages (as a user would).
Copy link

sonarqubecloud bot commented Apr 11, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
25.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants