footnotes without javascript #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kukimik
force-pushed
the
footnotes_no_js
branch
from
7e4f9a6 to
5947631
Compare
shivaraj-bh
pushed a commit
to shivaraj-bh/emanote
that referenced
this pull request
Dec 18, 2023
* footnotes without javascript * Up ver Co-authored-by: Sridhar Ratnakumar <[email protected]>
TristanCacqueray
added a commit
to TristanCacqueray/emanote
that referenced
this pull request
Jan 23, 2024
… similarly to srid#361
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the JS workaround of the
<base>tag vs anchor links issue, and also prepares the ground for #137.Be aware that this changes the behaviour of emanote when the user clicks a footnote link contained in an embedded note. However, footnotes in embedded notes are broken anyway #360 (and I think can be fixed in a reasonable way that is compatible with this PR), so maybe that's not a big issue.