Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use poetry for dependency management #103

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ArifNawaz36
Copy link

Pull Request Title

Use poetry for dependency management

Related Issue

#102

Description

Poetry will be used for package/dependency management instead of Pip. This will simplify the process of adding or removing new packages. A new package will be added using poetry add package-name command.

Type

  • Bug Fix
  • Feature Enhancement
  • Documentation Update
  • Code Refactoring
  • Other (please specify):

Proposed Changes

  • Two new files pyproject.toml and poetry.lock are added to use poetry for dependency management.
  • Update build.dockerfile to use poetry in docker images/containers
  • Update REAME.md

How to Test

  1. poetry install
  2. docker-compose up

Checklist

  • The code compiles successfully without any errors or warnings
  • The changes have been tested and verified
  • The documentation has been updated (if applicable)
  • The changes follow the project's coding guidelines and best practices
  • The commit messages are descriptive and follow the project's guidelines
  • All tests (if applicable) pass successfully
  • This pull request has been linked to the related issue (if applicable)

Additional Information

@srbhr
Copy link
Owner

srbhr commented Aug 9, 2023

Thanks for this PR @ArifNawaz36 I'll take a closer look, this will be more useful when we shift to FastAPI backend. As more and more changes + tests + environments would be required over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants