Upgrade IOS version to 1.7.2 #112
Conversation
mansi-square
commented
Apr 22, 2024
mansi-square
commented
- Upgrade IOS version to 1.7.2
- Upgrade app plugin version
1. Upgrade IOS version to 1.7.2 2. Upgrade app plugin version
|
|
| @@ -1,5 +1,9 @@ | |||
| ## Changelog | |||
|
|
|||
| ### v6.0.0 Apr 22st, 2024 | |||
There was a problem hiding this comment.
Let's just put "Apr 22" here. "Apr 22st" is not correct (same applies to line 7 - can you update this as well?)
| @@ -144,6 +144,7 @@ | |||
| 3B06AD1E1E4923F5004D2608 /* Thin Binary */, | |||
| 17130ABE28ACDC4A007FE54B /* Square setup script */, | |||
| 324E410A8DA310037B0B821B /* [CP] Embed Pods Frameworks */, | |||
| CB238059B6C64501CA7FAC41 /* [CP] Copy Pods Resources */, | |||
There was a problem hiding this comment.
I am not totally sure we want this at the end (does the setup script fail?) Need to check with @brandonjenniges on his thoughts. I think it's OK since it's just resources and I don't think the setups script is a resource?
There was a problem hiding this comment.
The Square setup script needs to be after both [CP] Embed Pods Frameworks and [CP] Copy Pods Resources
| @@ -3,7 +3,7 @@ | |||
| # | |||
| Pod::Spec.new do |s| | |||
| s.name = 'square_reader_sdk' | |||
| s.version = '3.0.0' | |||
There was a problem hiding this comment.
I am curious why this was 3.0.0 before?
There was a problem hiding this comment.
Looks like before it was attempting to be synced with this
.I think this podspec is never published to CocoaPods so I think technically we can down version it like this.. but maybe we won't to keep it in sync with the plugin version? So 5.0.0, it looks like is what we're calling this next version.
| @@ -1,5 +1,5 @@ | |||
| # Uncomment this line to define a global platform for your project | |||
| platform :ios, '11.1' | |||
| platform :ios, '14.0' | |||
There was a problem hiding this comment.
When trying to run the example app but getting some errors with deployement version and I see some other places that appear to need to update the target to 14.
square_reader_sdk.podspec's s.ios.deployment_target
Runner.xcodeproj/project.pbxproj is still referencing ios 11
|
I think this version number needs an update also. |
Fix launch screen contraints
