Skip to content

Conversation

andyf9
Copy link

@andyf9 andyf9 commented Apr 27, 2017

The meta url generator doesn't work as is for unsafe urls and should work the same way as the regular toUrlSafe method

The meta url generator doesn't work as is for unsafe urls and should work the same way as the regular toUrlSafe method
@JakeWharton
Copy link
Collaborator

We have test that verifies the output of this which will need updated. Do you have a link to the thumbor docs which specify this behavior?

@andyf9
Copy link
Author

andyf9 commented May 2, 2017

Sorry not to docs, this was just my experience of the current behaviour. I can raise it as an issue if you'd prefer.

The problem is that for a Thumbor url

http://localhost:8888/unsafe/https://www.google.co.uk/images/branding/googlelogo/1x/googlelogo_color_272x92dp.png

the equivalent meta url for Thumbor is
http://localhost:8888/unsafe/meta/https://www.google.co.uk/images/branding/googlelogo/1x/googlelogo_color_272x92dp.png

however, Pollexor is currently generating

http://localhost:8888/meta/https://www.google.co.uk/images/branding/googlelogo/1x/googlelogo_color_272x92dp.png

which just doesn't work.

I just looked at the existing toUrlUnsafe() method. The toMetaUnsafe() method needs to work the same way and prefix with the unsafe keyword.

@andyf9
Copy link
Author

andyf9 commented May 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants