Set apiVersion and languageVersion to 2.0 for backwards compatibility #1690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugoncosta
force-pushed
the
kotlin2.0Compatibility
branch
2 times, most recently
from
fab61f7 to
70db5ce
Compare
hugoncosta
force-pushed
the
kotlin2.0Compatibility
branch
from
70db5ce to
1d2a05a
Compare
|
Similar to the OkHttp PR mentioned above, limiting the scope of this change by only ensuring that the source sets remain compatible with Kotlin 2.0 - tests, which are already using 2.1+ features (like the new Clock and Instant) can remain on the latest version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion in square/okhttp#9032 and the PR in square/okhttp#9040, the purpose of this change is to ensure Okio remains compatible with Kotlin 2.0.
My change is only within the Okio package - to make the entire project compatible, there would need to be a few changes in other modules, more specifically adapting the usage of the new Kotlin Clock (see https://github.com/search?q=repo%3Asquare%2Fokio%20kotlin.time.Clock&type=code).