Allow setting NotBefore property via init and sign commands #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
notbefore
as an argument toinit
andsign
to allow setting NotBefore property. Ifnotbefore
is not supplied, theNotBefore
will be set as 10 minutes earlier than now. I believe this was intended to be the default behavior before, e.g.However,
Add
takes aDuration
as an argument, which is anint64
representing nanoseconds - so I don't think this behaved as described by the comment. I've changed the argument to-time.Minute * 10
. Let me know if I should keep it as-is.