Add config option to disable query validation #3642
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mp911de
reviewed
Oct 16, 2024
| @@ -120,6 +122,8 @@ public JpaRepositoryFactory(EntityManager entityManager) { | |||
| } | |||
|
|
|||
| this.crudMethodMetadata = crudMethodMetadataPostProcessor.getCrudMethodMetadata(); | |||
| String p = SpringProperties.getProperty("spring.data.jpa.query.validate"); | |||
There was a problem hiding this comment.
Let's not apply any defaulting from inside our library.
| @@ -118,6 +119,7 @@ public void postProcess(BeanDefinitionBuilder builder, RepositoryConfigurationSo | |||
| builder.addPropertyValue("transactionManager", transactionManagerRef.orElse(DEFAULT_TRANSACTION_MANAGER_BEAN_NAME)); | |||
| builder.addPropertyReference("entityManager", entityManagerRefs.get(source)); | |||
| builder.addPropertyValue(ESCAPE_CHARACTER_PROPERTY, getEscapeCharacter(source).orElse('\\')); | |||
| getQueryValidation(source).ifPresent(it -> builder.addPropertyValue(QUERY_VALIDATION, it)); | |||
There was a problem hiding this comment.
We don't need that one since we're not updating @EnableJpaRepositories
| QueryRewriter queryRewriter, ValueExpressionDelegate valueExpressionDelegate) { | ||
| this(method, em, method.getRequiredAnnotatedQuery(), countQueryString, queryRewriter, valueExpressionDelegate); | ||
| QueryRewriter queryRewriter, ValueExpressionDelegate valueExpressionDelegate, boolean validation) { | ||
| this(method, em, method.getRequiredAnnotatedQuery(), countQueryString, queryRewriter, valueExpressionDelegate, validation); |
There was a problem hiding this comment.
Probably a QueryValidator object would make sense instead of a magic boolean. I can handle that during the merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1690