Refine Specification API #3578
Open
Refine Specification API #3578
+1,749
−259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce DeleteSpecification and UpdateSpecification. Add PredicateSpecification. Update SpecificationExecutor.
mp911de
requested review from
christophstrobl,
schauder and
odrotbohm
and removed request for
christophstrobl
Gentle reminder to deprecate where before we remove it here
Revise nullability requirements around non-nullable specifications.
mp911de
force-pushed
the
main
branch
2 times, most recently
from
52ee55f to
61e6d36
Compare
|
LGTM |
schauder
approved these changes
Dec 19, 2024
| return (root, query, builder) -> { | ||
|
|
||
| Predicate not = spec.toPredicate(root, query, builder); | ||
| return not != null ? builder.not(not) : null; |
There was a problem hiding this comment.
That's so many not's, it's making knots in my brain. Could we at least reverse the comparison?
| static <T> Specification<T> anyOf(Iterable<Specification<T>> specifications) { | ||
|
|
||
| return StreamSupport.stream(specifications.spliterator(), false) // | ||
| .reduce(Specification.all(), Specification::or); |
There was a problem hiding this comment.
This looks really wrong to me. Specification.all() suggests a Specification that produces true for all inputs, which would always yield true when combined by OR with anything else.
I'd say the underlying problem is that all() is a misnomer. It should really be Specification.null() or Specification.empty(), shouldn't it?
| public interface UpdateSpecification<T> extends Serializable { | ||
|
|
||
| /** | ||
| * Simple static factory method to create a specification deleting all objects. |
There was a problem hiding this comment.
I assume that should read "updating all objects"
| * @param spec must not be {@literal null}. | ||
| * @return guaranteed to be not {@literal null}. | ||
| */ | ||
| static <T> UpdateOperation<T> update(UpdateOperation<T> spec) { |
There was a problem hiding this comment.
Comments and error message talk about UpdateSpecification but the types used are UpdateOperation. I'm confused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
DeleteSpecificationandUpdateSpecification. AddPredicateSpecification. UpdateSpecificationExecutor.See #3521