Fix string return conversion in DefaultToolCallResultConverter #3756
+9
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valery1707
reviewed
Jul 10, 2025
...odel/src/main/java/org/springframework/ai/tool/execution/DefaultToolCallResultConverter.java
Outdated
Show resolved
Hide resolved
valery1707
reviewed
Jul 10, 2025
| @@ -22,6 +22,7 @@ | |||
| import java.lang.reflect.Type; | |||
| import java.util.Base64; | |||
| import java.util.Map; | |||
| import java.util.Optional; | |||
There was a problem hiding this comment.
Thanks for the review! I've squashed the optimization commits into one and pushed the update.
JM-Lab
force-pushed
the
fix-string-returntype-no-json-conversion
branch
from
77ecb6c to
e01be9e
Compare
valery1707
reviewed
Jul 11, 2025
| import org.springframework.ai.util.json.JsonParser; | ||
| import org.springframework.lang.Nullable; | ||
|
|
||
| import javax.imageio.ImageIO; |
There was a problem hiding this comment.
Fixed imports, squashed commits, and pushed. Thanks for the review!
…ResultConverter Signed-off-by: Jemin Huh <[email protected]>
JM-Lab
force-pushed
the
fix-string-returntype-no-json-conversion
branch
from
e01be9e to
5864958
Compare
valery1707
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return String tool results directly (or "null" if null) when returnType is String.class, instead of serializing them to JSON. This removes unnecessary formatting while preserving existing behavior for other types.