Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Dockerfile-frontend with upstream to fix docker-compose build #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions Dockerfile-frontend
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,16 @@
# Use a docker image with NODE to build the deliverable
# Build everywhere
####################################################################
ARG DOCKER_HUB="docker.io"
ARG NGINX_VERSION="1.17.6"
ARG NODE_VERSION="16.3-alpine"

FROM node:12 as build
FROM $DOCKER_HUB/library/node:$NODE_VERSION as build
MAINTAINER Cedrick Lunven

# Get Sources
RUN apt update && \
apt install -y git && \
RUN apk update && \
apk add git && \
git clone https://github.com/spring-petclinic/spring-petclinic-angular.git /workspace

ARG NPM_REGISTRY=" https://registry.npmjs.org"
Expand All @@ -27,7 +30,8 @@ RUN echo "export const environment = {production: false, REST_API_URL: 'http://
# Use the DIST folder to package an image with NGINX.
####################################################################

FROM nginx:1.19.4 AS runtime
FROM $DOCKER_HUB/library/nginx:$NGINX_VERSION AS runtime


COPY --from=build /workspace/dist/ /usr/share/nginx/html/

Expand Down