Skip to content

Fixed #152 #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixed #152 #154

wants to merge 1 commit into from

Conversation

davebarda
Copy link

@davebarda davebarda commented Dec 9, 2019

No description provided.

@pivotal-issuemaster
Copy link

@davebarda Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@davebarda Thank you for signing the Contributor License Agreement!

@wilkinsona
Copy link
Contributor

Thanks for the pull request but this won't quite have the right effect. It will ban the use of org.testng.annotations.Test. This will result in a failure when org.testng.annotations.test is used rather than the current failure that requires the method to not be public. In short, we'd swap one failure for another which will not address the problem in Spring Boot's build. Thanks anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants