Allow annotation processors for tests#1770
Closed
aggmegalou wants to merge 1 commit intospring-io:mainfrom
Closed
Conversation
Add opt-in support for annotation processor dependencies (e.g. Lombok) to be available for test compilation when using Gradle. When metadata sets annotationProcessorForTests: true, the dependency is added to both annotationProcessor and testAnnotationProcessor configurations. - Add annotationProcessorForTests flag to Dependency metadata - Add TEST_ANNOTATION_PROCESSOR scope to DependencyScope - Map scope in GradleBuildWriter and MavenBuildWriter - Add testCompileOnly.extendsFrom(testAnnotationProcessor) in Gradle customizer - Resolve test annotation processor dependency in DefaultProjectRequestToDescriptionConverter - Add MetadataBuildItemMapper.toDependency overload with scope override - Add tests and BuildComplianceTests for end-to-end verification Closes spring-iogh-1380 Signed-off-by: Aggeliki <aggmegalou@gmail.com>
ce88ab4 to
cbbab4f
Compare
Contributor
|
Hey, thanks for the PR. After looking at it and the current arrangement, I think we have more refactoring to do, which is out of scope for this PR.
I'll open separate issues for this and close the PR. Thanks anyway! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add opt-in support for annotation processor dependencies (e.g. Lombok) to be available for test compilation when using Gradle. When metadata sets annotationProcessorForTests: true, the dependency is added to both annotationProcessor and testAnnotationProcessor configurations.
Closes gh-1380