Apply Java modernization idioms across the codebase#1757
Closed
eunseo9311 wants to merge 1 commit intospring-io:mainfrom
Closed
Apply Java modernization idioms across the codebase#1757eunseo9311 wants to merge 1 commit intospring-io:mainfrom
eunseo9311 wants to merge 1 commit intospring-io:mainfrom
Conversation
Replace String.format() with String.formatted() and apply instanceof pattern matching to align with the established conventions already used throughout the project. Signed-off-by: eunseo9311 <eunseo9311@gmail.com> Signed-off-by: Eunseo Song <162149585+eunseo9311@users.noreply.github.com>
Contributor
Author
|
The CI failure is caused by a transient Could you re-run the CI when you get a chance? |
mhalbritter
pushed a commit
that referenced
this pull request
Feb 23, 2026
Replace String.format() with String.formatted() and apply instanceof pattern matching to align with the established conventions already used throughout the project. See gh-1757 Signed-off-by: eunseo9311 <eunseo9311@gmail.com> Signed-off-by: Eunseo Song <162149585+eunseo9311@users.noreply.github.com>
mhalbritter
added a commit
that referenced
this pull request
Feb 23, 2026
Contributor
|
Thanks @eunseo9311 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: Apply Java modernization idioms across the codebase
Apply Java modernization idioms across the codebase
Summary
String.format()withString.formatted()to align with the convention already established by project maintainers since May 2023instanceofpattern matching (Java 16+) to remaining old-styleinstanceofchecks with explicit casts, consistent with the 38 instances already using the modern syntaxDetails
Test plan
./mvnw clean installpasses./mvnw spring-javaformat:applyproduces no additional changes./mvnw validate(checkstyle) passes