Conversation
Member
Author
|
@haviv1idan you can also check out the PR. I've included some of your changes, but not all. For some, I have added a comment to your PR (#1165) |
|
Why mix |
haviv1idan
suggested changes
Dec 6, 2024
There was a problem hiding this comment.
@dieser-niko Very nice job.
Just a few suggestions to keep consistency in code
Member
Author
|
Yeah honestly I don't know what went through my mind. I guess I preferred to use .format() because it would be easier to read, but I agree, consistency would actually be better. Currently I don't have the time to fix, expect activity in the next month. |
stephanebruckert
approved these changes
Jan 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1159
There are some capitalisations in there as well.
Also, I had to change the playlist in
examples/follow_playlist.pyto a user playlist due to the recent API changes.