You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After glancing over the codebase, I came across code blocks that could be refactored to make them more maintainable and easier to read. Also, some refactors can make the code more "Pythonic". and performant. I have a few ideas in mind and most of them are:-
using if expressions than if conditions
list comprehensions instead of a for loop for smaller logical blocks.
Usage of f-strings ( I saw that the env supports 3.4 but f-strings have been added from Python 3.6). So should I refactor this?
Simplifying if/else code blocks to be more concise.
Merge nested conditional clauses.
Please let me know what Python version should be supported for these refactors and I'll get to work on it.
The text was updated successfully, but these errors were encountered:
If possible, I think we should lift minimum Python version requirement to 3.6/3.7 since we can really improve the readability and efficiency of the code.
About the python support, it should be fair to only support >= 3.8 as 3.7 security support ends in June 2023 https://endoflife.date/python, so feel free to use f-strings.
Thanks for any contribution!
PS: that v3 branch is a bit out of sync with the main branch, as it needs a rebase which I have in progress. Just to let you know that conflicts may arise, but we will have all the time to fix them.
After glancing over the codebase, I came across code blocks that could be refactored to make them more maintainable and easier to read. Also, some refactors can make the code more "Pythonic". and performant. I have a few ideas in mind and most of them are:-
Please let me know what Python version should be supported for these refactors and I'll get to work on it.
The text was updated successfully, but these errors were encountered: