Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codebase Refactor for v3 #961

Open
wants to merge 2 commits into
base: v3
Choose a base branch
from

Conversation

HighnessAtharva
Copy link

workerB
Implemented suggestions for #652. Handles all proposed changes in #960
Most of these changes include:-

  • Using if expressions than if conditions list comprehensions instead of a for loop for smaller logical blocks.
  • Usage of f-strings ( I saw that the env supports 3.4 but f-strings have been added from Python 3.6). So should I refactor this?
  • Simplifying if/else code blocks to be more concise.
  • Merge nested conditional clauses.

Implemented suggestions for spotipy-dev#652
Major changes include:-
- Using if expressions than if conditions
list comprehensions instead of a for loop for smaller logical blocks.
- Usage of f-strings ( I saw that the env supports 3.4 but f-strings have been added from Python 3.6). So should I refactor this?
- Simplifying if/else code blocks to be more concise.
- Merge nested conditional clauses.
@stephanebruckert
Copy link
Member

Thanks! There are flake8 conflicts which you can fix following https://github.com/spotipy-dev/spotipy/blob/master/CONTRIBUTING.md#lint

@sigma67
Copy link

sigma67 commented Aug 20, 2023

Please address #1021 if you can, it's trivial to implement. See suggestion there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants