Skip to content
This repository has been archived by the owner on Jan 17, 2019. It is now read-only.

Move layout logic into the collection view factory #331

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

cerihughes
Copy link
Contributor

Create a collection view layout in the collection view factory when we create the collection view, and absolve the view controller of that responsibility. The VC now also doesn't need to create a "temporary" UICollectionViewLayout class for the collection view.

@spotify-ci-bot
Copy link

spotify-ci-bot commented Apr 12, 2017

3 Messages
📖 Executed 383 tests, with 0 failures (0 unexpected) in 6.960 (7.509) seconds
📖 Executed 379 tests, with 0 failures (0 unexpected) in 6.604 (7.246) seconds
📖 Executed 11 tests, with 0 failures (0 unexpected) in 212.274 (212.282) seconds

Generated by 🚫 Danger

@codecov-io
Copy link

codecov-io commented Apr 12, 2017

Codecov Report

Merging #331 into master will decrease coverage by 0.37%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #331      +/-   ##
=========================================
- Coverage   80.57%   80.2%   -0.38%     
=========================================
  Files          84      84              
  Lines        5659    4500    -1159     
=========================================
- Hits         4560    3609     -951     
+ Misses       1099     891     -208
Impacted Files Coverage Δ
...rces/HUBViewControllerExperimentalImplementation.m 4.68% <ø> (-0.13%) ⬇️
sources/HUBViewControllerImplementation.m 88.3% <ø> (-1.82%) ⬇️
sources/HUBConfigViewControllerFactory.m 96.66% <100%> (-0.71%) ⬇️
sources/HUBViewControllerFactoryImplementation.m 100% <100%> (ø) ⬆️
sources/HUBCollectionViewFactory.m 100% <100%> (ø) ⬆️
sources/HUBLiveServiceFactory.m 75% <0%> (-5%) ⬇️
sources/HUBComponentUIStateManager.m 85.71% <0%> (-3.18%) ⬇️
sources/HUBLiveServiceImplementation.m 81.39% <0%> (-2.92%) ⬇️
sources/HUBIdentifier.m 91.66% <0%> (-2.09%) ⬇️
sources/HUBCollectionContainerView.m 90.9% <0%> (-1.95%) ⬇️
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84a7b19...f679dfc. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants