This repository has been archived by the owner on Sep 25, 2020. It is now read-only.
g11n + L10n fr #22
Merged
g11n + L10n fr #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing to change EN)
…and workshopper-boilerplate
|
This is great, thanks |
|
Hey Sebastian, Yay 🎉 wonderful to see this moving forward. Don't worry about not making it in time for last Saturday, the few people playing with Looking forward to the updated version on npm. Would you be kind enough to notify me here when it's out? Thanks again! |
|
@tdd I have published the latest version to npm with the french localisation |
|
Kickass, thank you! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Sebastian,
First, thanks for Planet Proto, it's a great workshop! One of the few that uses the boilerplate system, too, bravo!
Related to the nodeschool/organizers#64 efforts, I'm in the process of upgrading most workshops to the latest versions of the infra modules (
workshopper,workshopper-exerciseandworkshopper-boilerplate) and addingfrL10n for them.This is the result for Planet Proto. It's been entirely tested again, in English and French, and works well.
I also took the liberty to use variations of the reference solution codes that closely mirrors the boilerplates; I suspect these evolved post-solution, and I find it's easier for "students" to read the solutions when the comments and structure from the boilerplates remains. I'd be happy to do that for the ref English solution too if you like this idea.
Would you consider merging that in and bumping on npm before Saturday? This would make it easier for French attendees of NodeSchool Paris #1 to tackle it if they feel English adds too much friction.
Naturally, I'm available for any questions or discussion on this.
Best,