Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK 22 CI build #1935

Merged
merged 7 commits into from
May 15, 2024
Merged

JDK 22 CI build #1935

merged 7 commits into from
May 15, 2024

Conversation

szpak
Copy link
Member

@szpak szpak commented Mar 24, 2024

This PR adds JDK 22 CI build.

I don't see a good reason to build with both 21 LTS and 22, so the former is replaced by the later.

As a bonus, I also improved the visibility in GitHub Actions UI, the order of matrix variables has been changed (I might move it to a separate PR, if desired).

Before (JDK version and Groovy variant are not visible in the failing builds):
image

After:
Screenshot from 2024-03-24 20-33-43

@szpak
Copy link
Member Author

szpak commented Mar 24, 2024

@leonard84 It seems you need to click somewhere in the project settings to choose the new "mandatory checks".

@Vampire
Copy link
Member

Vampire commented Mar 24, 2024

It seems you need to click somewhere in the project settings to choose the new "mandatory checks".

After it was decided to merge the PR, yep.
Otherwise all other PRs will miss required checks until this eventually got merged maybe.
But don't worry, he can merge the PR even with the required checks missing due to the rename. :-)

I don't see a good reason to build with both 21 LTS and 22, so the former is replaced by the later.

Well, 21 is LTS 22 is latest.
Imho that might well be reason enough to build for both.

@szpak
Copy link
Member Author

szpak commented Mar 24, 2024

After it was decided to merge the PR, yep.
Otherwise all other PRs will miss required checks until this eventually got merged maybe.

Sure. That was my intention.

Well, 21 is LTS 22 is latest.
Imho that might well be reason enough to build for both.

We have already a large number of builds. Initially, I was thinking about limiting a number of builds with "intermediate" versions. However, in the end, the two extra build (21 with 3.0 and 4.0) would probably not be a big problem.

@szpak
Copy link
Member Author

szpak commented Mar 24, 2024

the two extra build (21 with 3.0 and 4.0) would probably not be a big problem.

Sometimes 4 builds - for a push and for a PR (I will start making my branches in my fork).

Vampire
Vampire previously approved these changes Mar 25, 2024
Copy link
Member

@Vampire Vampire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but Leonard should have the last word and especially merge it to then adapt the required checks.

@szpak szpak requested a review from leonard84 March 25, 2024 17:43
.github/workflows/branches-and-prs.yml Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
@szpak
Copy link
Member Author

szpak commented May 14, 2024

@leonard84 Any more suggestions here?

@leonard84 leonard84 merged commit f538921 into master May 15, 2024
44 checks passed
@leonard84 leonard84 deleted the szpak/jdk22 branch May 15, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants