Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include and use GNUInstallDirs in cmake #85

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Conversation

pclouds
Copy link
Contributor

@pclouds pclouds commented Dec 15, 2024

This installs libfastgltf.a in the expected directory. On many Linux distros this will be /usr/lib64, not /usr/lib. And this is important when the distro supports both 32 and 64 bits (32 libs go to /usr/lib)

This installs libfastgltf.a in the expected directory. On many Linux
distros this will be /usr/lib64, not /usr/lib. And this is important
when the distro supports both 32 and 64 bits (32 libs go to /usr/lib)
@spnda
Copy link
Owner

spnda commented Feb 24, 2025

First of all sorry for the late response. Do you know if this has any impact on things like vcpkg or conan? It just feels a little weird it being called GNUInstallDirs. Otherwise I'd be fine with this.

@pclouds
Copy link
Contributor Author

pclouds commented Mar 4, 2025

I don't even have Windows so vckpg is out of question for me. Some vcpkg ticket (microsoft/vcpkg#156) does mention GNUInstallDirs though so I don't think it will cause any problem. GNUInstallDris was made working with conan too, it seems in conan-io/conan#14733.

I think this will only affect the installation phase, so if people build and use in-tree it won't have any impact whatsoever. Otherwise it will only define some variables to follow GNU Coding Standards which is the "GNU" part in GNUInstallDirs

@spnda
Copy link
Owner

spnda commented Mar 4, 2025

Ok sure, I think I'll just merge this and see if anybody complains. I think most of the time the folders would resolve to the same as before anyway.

@spnda spnda merged commit 6cd95aa into spnda:main Mar 4, 2025
@spnda spnda added enhancement New feature or request done Everything has been addressed labels Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done Everything has been addressed enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants