Fix: record tracker does not support concurrent event batch removal #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludovic-boutros
had a problem deploying
to
workflow-approval
GitHub Actions
Failure
ludovic-boutros
force-pushed
the
fix-concurrent-delete-in-record-tracker
branch
from
2446868
to
79a33dc
Compare
ludovic-boutros
had a problem deploying
to
workflow-approval
GitHub Actions
Failure
ludovic-boutros
force-pushed
the
fix-concurrent-delete-in-record-tracker
branch
from
79a33dc
to
077178b
Compare
ludovic-boutros
had a problem deploying
to
workflow-approval
GitHub Actions
Failure
ludovic-boutros
force-pushed
the
fix-concurrent-delete-in-record-tracker
branch
from
077178b
to
62c39d6
Compare
ludovic-boutros
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
|
I have rewritten the code using a far simpler approach. |
|
Hi @ludovic-boutros. I took over this project after @VihasMakwana. I'll look into this PR |
wojtekzyla
approved these changes
May 6, 2024
Unit Test Results173 tests 173 ✅ 38s ⏱️ Results for commit 62c39d6. |
ludovic-boutros
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
|
Hello @wojtekzyla, any news on this issue? This is a critical issue for my customer. |
ludovic-boutros
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
ludovic-boutros
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
|
Thank you, @wojtekzyla! Would it be possible to make a release, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix the issue #423.
The record tracker uses
ConcurrentNavigableMapiterators.These iterators are Weakly-Consistent iterators.
That means that a thread will not see reflected changes made by another concurrent thread.
Therefore, events can be removed multiple times and the total number of event is not accurate and can become a negative number.
The idea of this fix is to first make sure that the total number of event never become a negative number anymore and given the strategy, we don't need to clean the event batches in parallel. Only one thread needs do the job at some point.
Another approach would be to use the batch input parameter of the function
removeAckedEventBatches, but I did not want to change the design too much.