Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Disable mandatory field validation if validation is disabled #424

Merged

Conversation

ludovic-boutros
Copy link
Contributor

This PR is a proposal for fixing the issue #421.
Currently, in order to test if the configuration validation is enabled or not, a configuration object is build.
But during this process, mandatory fields are checked, already causing an exception.

Copy link
Contributor

@VihasMakwana VihasMakwana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Unit Test Results

171 tests  +1   171 ✅ +1   38s ⏱️ ±0s
 24 suites ±0     0 💤 ±0 
 24 files   ±0     0 ❌ ±0 

Results for commit 8f16817. ± Comparison against base commit ba29847.

@VihasMakwana VihasMakwana merged commit 0d009fc into splunk:develop Mar 11, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants