Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude more un-diffable objects #273

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Exclude more un-diffable objects #273

merged 2 commits into from
Nov 8, 2024

Conversation

lucaseras
Copy link
Contributor

Closes #268

Copy link
Collaborator

@jas14 jas14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thank you!

@jas14 jas14 merged commit 8c827b6 into main Nov 8, 2024
31 checks passed
@jas14 jas14 deleted the lucas/exclude-undiffables branch November 8, 2024 22:40
jas14 pushed a commit that referenced this pull request Nov 8, 2024
Closes #268.

SuperDiff already skips diff output for incomparable types, such as `true`, `false`, and `nil`. We will now also skip diff output when comparing the following types (for which we can't produce a meaningful diff):

* `Symbol`
* `Numeric`
* `Regexp`
* `Class`
* `Module`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclude more un-diffable objects
2 participants