Bot Setups feature relates to #94 #115
Conversation
skliffmueller
changed the title
|
Getting it to build, didn't have docker handy at the time. Damn ESEA blocking virtualization. So had to spool up a docker on a remote host and get a server running. Will post results. |
skliffmueller
force-pushed
the
master
branch
2 times, most recently
from
c632939
to
bd37322
Compare
…s to have an optional argument .loadbots <myprofile> .savebots <myprofile> while still being backwards compatable with original .loadbots .savebots commands Updated README to include bot setups, tabs vs spaces Bot Setups: Fixed build issues Bot Setups: Fixed build issues Stuff Fixing more variable issues Fixing stuff
.removebotsetup <setup>) Updated README to include bot setups, tabs vs spaces Fixed sizeof reference Fixed symlink Stuff Fixing more variable issues Fixing stuff debug message Debugging debug stuff More debugging stuff Fixed compile error bla asd asdasd bug fixes strlen not sizeof debug print stuff fix list fix tweaks more bug fixes stuff Finished
|
It's done and tested. I added .removebotsetup as I can imagine over time people having too many configs. |
|
Thanks for taking a shot at this. I'll try to take a further look soon. One thing from a quick pass: it looks like you're using a separate file for each setup, which gets named by the user. I think it'd be strongly preferable to continue using a single file for all bot-info on each file. The keyvalues structure allows for things to be nested. It's a little awkward because of the existing saving/loads of named bot positions. I'm not sure how that should interplay with this new feature, or if that should even exist at all. It didn't really turn out to work very well so I'd be okay if it was removed. And on a slightly more trivial note: keeping the style in line with all the code would be nice too. From a quick glance, I see some inconsistencies from the existing code. The existing code uses |
|
I will improve on this soon. With the work week, improvements will be delayed. Another thought. For a legacy fallback. The old data format can be detected on load, and transformed into the new KeyValue object format using the "default" key, and save would just save into the new format overwriting the file. |
|
@skliffmueller Any luck with the changes? This looks like a great addition too. |
Fully tested and ready.