Skip to content

Commit

Permalink
centralize lombok dependencies in build.gradle and use enforcedPlatfo…
Browse files Browse the repository at this point in the history
…rm with kork-bom (#1069)

* chore(dependencies): centralize lombok dependencies in build.gradle

to remove duplication.  Also add a testCompileOnly dependency to make lombok available to
test code and to follow https://projectlombok.org/setup/gradle.

* chore(dependencies): use enforcedPlatform with kork-bom

since it really is supposed to determine what versions of dependencies to use.  This also matches what [clouddriver](https://github.com/spinnaker/clouddriver/blob/3f31190d40419218fd1d31ca78bb1661f1ef881a/build.gradle) does.

No differences in the output of:
```
alias gradle-all-deps='./gradlew --no-parallel --stacktrace dependencies $(./gradlew -q projects \
    | grep -Fe ---\ Project \
    | sed -Ee "s/^.+--- Project '"'([^']+)'/\1:dependencies/"'" | sort)'
```
  • Loading branch information
dbyron-sf committed Feb 21, 2024
1 parent b85314f commit 2eb8bee
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
10 changes: 8 additions & 2 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,17 @@ subprojects {
dependencies {
implementation enforcedPlatform("io.spinnaker.kork:kork-bom:$korkVersion")

annotationProcessor platform("io.spinnaker.kork:kork-bom:$korkVersion")
compileOnly "org.projectlombok:lombok"

annotationProcessor enforcedPlatform("io.spinnaker.kork:kork-bom:$korkVersion")
annotationProcessor "org.projectlombok:lombok"
annotationProcessor("org.springframework.boot:spring-boot-configuration-processor")
testAnnotationProcessor platform("io.spinnaker.kork:kork-bom:$korkVersion")

testCompileOnly "org.projectlombok:lombok"

testAnnotationProcessor enforcedPlatform("io.spinnaker.kork:kork-bom:$korkVersion")
testAnnotationProcessor "org.projectlombok:lombok"

testRuntimeOnly "org.junit.jupiter:junit-jupiter-engine"
}

Expand Down
3 changes: 0 additions & 3 deletions rosco-core/rosco-core.gradle
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
dependencies {
compileOnly "org.projectlombok:lombok"
annotationProcessor "org.projectlombok:lombok"

api "io.spinnaker.kork:kork-artifacts"
api "io.spinnaker.kork:kork-plugins"
api "org.codehaus.groovy:groovy"
Expand Down
3 changes: 0 additions & 3 deletions rosco-manifests/rosco-manifests.gradle
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
dependencies {
implementation project(":rosco-core")

compileOnly "org.projectlombok:lombok"
annotationProcessor "org.projectlombok:lombok"

implementation "org.springframework.boot:spring-boot-starter-web"
implementation "io.spinnaker.kork:kork-artifacts"
implementation "io.spinnaker.kork:kork-exceptions"
Expand Down

0 comments on commit 2eb8bee

Please sign in to comment.