fix(jenkins): Wrong Job name encoding in query params for Artifacts/Properties #4722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonmcintosh
approved these changes
May 3, 2024
|
Be nice to get some MockWebServer classes to test these at some point... :P NOT sure if that's viable here. |
|
@jasonmcintosh @ovidiupopa07 Added some mock tests to catch these issues in the future |
christosarvanitis
force-pushed
the
fix-issue-6949
branch
from
73e793f
to
04efddd
Compare
jasonmcintosh
approved these changes
May 8, 2024
orca-igor/src/test/groovy/com/netflix/spinnaker/orca/igor/BuildServiceSpecMock.groovy
Outdated
Show resolved
Hide resolved
jasonmcintosh
requested changes
May 8, 2024
ovidiupopa07
approved these changes
May 9, 2024
|
@Mergifyio backport release-1.34.x release-1.33.x release-1.32.x |
✅ Backports have been created
|
mergify bot
added a commit
that referenced
this pull request
May 9, 2024
…roperties (#4722) (#4723) * fix(jenkins): Wrong Job name encoding in query params for Artifacts/Properties * fix(jenkins): Wrong Job name encoding in query params - added Wiremock tests * fix(jenkins): Wrong Job name encoding in query params - fix Wiremock tests imports (cherry picked from commit b2dba59) Co-authored-by: Christos Arvanitis <[email protected]>
mergify bot
added a commit
that referenced
this pull request
May 9, 2024
…roperties (#4722) (#4724) * fix(jenkins): Wrong Job name encoding in query params for Artifacts/Properties * fix(jenkins): Wrong Job name encoding in query params - added Wiremock tests * fix(jenkins): Wrong Job name encoding in query params - fix Wiremock tests imports (cherry picked from commit b2dba59) Co-authored-by: Christos Arvanitis <[email protected]>
mergify bot
added a commit
that referenced
this pull request
May 9, 2024
…roperties (#4722) (#4725) * fix(jenkins): Wrong Job name encoding in query params for Artifacts/Properties * fix(jenkins): Wrong Job name encoding in query params - added Wiremock tests * fix(jenkins): Wrong Job name encoding in query params - fix Wiremock tests imports (cherry picked from commit b2dba59) Co-authored-by: Christos Arvanitis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue spinnaker/spinnaker#6949 when jobNameAsQueryParameter is enabled and Job Name includes spaces.
Introduced by #4661