feat(jenkins): Enable Jenkins job triggers for jobs in sub-folders #4618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow triggering of Jenkins jobs that reside in sub-folders, by treating job names containing slashes as query variables. - Prior to this feature, jobs in sub-folders were not appropriately matched by the Spring framework due to slashes in their path, causing trigger requests to fail. - Include a new feature flag to determine the usage of the existing endpoint (which uses the job name as a path variable) or an updated endpoint (which takes the job name as a query parameter).
This was referenced Dec 14, 2023
| Map<String, Object> getBuildWithJobAsQueryParam( | ||
| @Path("buildNumber") Integer buildNumber, | ||
| @Path("master") String master, | ||
| @Query(encodeValue = false, value = "job") String job); |
There was a problem hiding this comment.
One concern here is on the encodeValue... if there are any kinda characters in the job name, I could see this not working UNLESS they're encoded. Wouldn't think "job" but... it's a caution flag.
jasonmcintosh
approved these changes
Dec 21, 2023
|
@Mergifyio backport release-1.28.x release-1.30.x release-1.31.x release-1.32.x release-1.33.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 22, 2024
…4618) * feat(jenkins): Enable Jenkins job triggers for jobs in sub-folders - Allow triggering of Jenkins jobs that reside in sub-folders, by treating job names containing slashes as query variables. - Prior to this feature, jobs in sub-folders were not appropriately matched by the Spring framework due to slashes in their path, causing trigger requests to fail. - Include a new feature flag to determine the usage of the existing endpoint (which uses the job name as a path variable) or an updated endpoint (which takes the job name as a query parameter). * feat(jenkins): initiate flag to false in tests (cherry picked from commit 13c6f6e) # Conflicts: # orca-igor/src/main/java/com/netflix/spinnaker/orca/igor/IgorFeatureFlagProperties.java
mergify bot
pushed a commit
that referenced
this pull request
Jan 22, 2024
…4618) * feat(jenkins): Enable Jenkins job triggers for jobs in sub-folders - Allow triggering of Jenkins jobs that reside in sub-folders, by treating job names containing slashes as query variables. - Prior to this feature, jobs in sub-folders were not appropriately matched by the Spring framework due to slashes in their path, causing trigger requests to fail. - Include a new feature flag to determine the usage of the existing endpoint (which uses the job name as a path variable) or an updated endpoint (which takes the job name as a query parameter). * feat(jenkins): initiate flag to false in tests (cherry picked from commit 13c6f6e)
mergify bot
pushed a commit
that referenced
this pull request
Jan 22, 2024
…4618) * feat(jenkins): Enable Jenkins job triggers for jobs in sub-folders - Allow triggering of Jenkins jobs that reside in sub-folders, by treating job names containing slashes as query variables. - Prior to this feature, jobs in sub-folders were not appropriately matched by the Spring framework due to slashes in their path, causing trigger requests to fail. - Include a new feature flag to determine the usage of the existing endpoint (which uses the job name as a path variable) or an updated endpoint (which takes the job name as a query parameter). * feat(jenkins): initiate flag to false in tests (cherry picked from commit 13c6f6e)
mergify bot
pushed a commit
that referenced
this pull request
Jan 22, 2024
…4618) * feat(jenkins): Enable Jenkins job triggers for jobs in sub-folders - Allow triggering of Jenkins jobs that reside in sub-folders, by treating job names containing slashes as query variables. - Prior to this feature, jobs in sub-folders were not appropriately matched by the Spring framework due to slashes in their path, causing trigger requests to fail. - Include a new feature flag to determine the usage of the existing endpoint (which uses the job name as a path variable) or an updated endpoint (which takes the job name as a query parameter). * feat(jenkins): initiate flag to false in tests (cherry picked from commit 13c6f6e)
This was referenced Jan 22, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jan 22, 2024
…4618) * feat(jenkins): Enable Jenkins job triggers for jobs in sub-folders - Allow triggering of Jenkins jobs that reside in sub-folders, by treating job names containing slashes as query variables. - Prior to this feature, jobs in sub-folders were not appropriately matched by the Spring framework due to slashes in their path, causing trigger requests to fail. - Include a new feature flag to determine the usage of the existing endpoint (which uses the job name as a path variable) or an updated endpoint (which takes the job name as a query parameter). * feat(jenkins): initiate flag to false in tests (cherry picked from commit 13c6f6e)
mergify bot
added a commit
that referenced
this pull request
Feb 13, 2024
…4618) (#4635) * feat(jenkins): Enable Jenkins job triggers for jobs in sub-folders - Allow triggering of Jenkins jobs that reside in sub-folders, by treating job names containing slashes as query variables. - Prior to this feature, jobs in sub-folders were not appropriately matched by the Spring framework due to slashes in their path, causing trigger requests to fail. - Include a new feature flag to determine the usage of the existing endpoint (which uses the job name as a path variable) or an updated endpoint (which takes the job name as a query parameter). * feat(jenkins): initiate flag to false in tests (cherry picked from commit 13c6f6e) Co-authored-by: Raul Cristian <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Feb 13, 2024
…4618) (#4634) * feat(jenkins): Enable Jenkins job triggers for jobs in sub-folders - Allow triggering of Jenkins jobs that reside in sub-folders, by treating job names containing slashes as query variables. - Prior to this feature, jobs in sub-folders were not appropriately matched by the Spring framework due to slashes in their path, causing trigger requests to fail. - Include a new feature flag to determine the usage of the existing endpoint (which uses the job name as a path variable) or an updated endpoint (which takes the job name as a query parameter). * feat(jenkins): initiate flag to false in tests (cherry picked from commit 13c6f6e) Co-authored-by: Raul Cristian <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Mar 14, 2024
…4618) (#4633) * feat(jenkins): Enable Jenkins job triggers for jobs in sub-folders - Allow triggering of Jenkins jobs that reside in sub-folders, by treating job names containing slashes as query variables. - Prior to this feature, jobs in sub-folders were not appropriately matched by the Spring framework due to slashes in their path, causing trigger requests to fail. - Include a new feature flag to determine the usage of the existing endpoint (which uses the job name as a path variable) or an updated endpoint (which takes the job name as a query parameter). * feat(jenkins): initiate flag to false in tests (cherry picked from commit 13c6f6e) Co-authored-by: Raul Cristian <[email protected]> Co-authored-by: Jason <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When defining a Jenkins job in a sub-folder, the path contains slashes. Consequently, the Spring framework is not capable of accurately matching the request.
Problem
The trigger request fails because it is attempting to initiate a job that is not found.
Solution
A feature flag has been added. This flag influences if we should call the existing endpoint (which accepts the job name as a path variable) or the new one (which accepts the job name as a query parameter).
Before
After
Related PR's
Echo: spinnaker/echo#1373
Igor: spinnaker/igor#1204