Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(deploymentmonitor): Configure SpinnakerRetrofitErrorHandler for DeploymentMonitorService #4614

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor(deploymentmonitor): Configure SpinnakerRetrofitErrorHandler for DeploymentMonitorService #4614

wants to merge 2 commits into from

Commits on Jan 4, 2024

  1. test(deploymentmonitor): Add Test Case for EvaluateDeploymentTask 

    This commit introduces a test case aimed at demonstrating the existing behaviour of the ‘EvaluateDeploymentTask’ task. The primary objective of this test case is to verify the proper handling of ‘RetrofitError’ thrown by the retrofit client when interacting with DeploymentMonitorService APIs.

Details:
- Added a dedicated test case to assess the behaviour of ‘EvaluateDeploymentTask’.
- The test case specifically focuses on handling ‘RetrofitError’ instances thrown by DeploymentMonitorService APIs.
- This step is essential for understanding and validating the current behaviour of the task in response to potential errors during API interactions.

This test case serves as a baseline for future modifications and enhancements related to the ‘EvaluateDeploymentTask’.
    @Pranav-b-7
    Pranav-b-7 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    11438e9 View commit details
    Browse the repository at this point in the history

  2. refactor(deploymentmonitor): Configure SpinnakerRetrofitErrorHandler … 

    …for DeploymentMonitorService

Update the error handler for the retrofit client, DeploymentMonitorService, to use SpinnakerRetrofitErrorHandler. Additionally, modify catch blocks with RetrofitError to use Spinnaker*Exception.

Purpose : This commit is foundational work for upgrading the Retrofit version to retrofit2.x

Behavioural change : The modification includes updating catch blocks, leading to a change in the format of logger messages. This aligns with the upcoming modifications discussed in the PR: spinnaker#4608

Additionally, when the error response body is null, an appropriate error message will be printed in the logger.
    @Pranav-b-7
    Pranav-b-7 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    52e528f View commit details
    Browse the repository at this point in the history