Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lambda): rewrite to use Kato/Oort #4492

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mattgogerly
Copy link
Member

@mattgogerly mattgogerly commented Jul 27, 2023

As promised, cleaning up the Lambda stages to use Kato/Oort rather than directly calling Clouddriver. Couple of other bits of cleanup too.

  • Use Kato to request Lambda ops and check status
  • Use Oort to get Lambdas from cache
  • Use existing stage.mapTo() to map context to classes rather than custom util
  • Use builders rather than setting properties
  • Use HttpStatus enum rather than magic numbers

@kyledmitchell
Copy link

Hey @mattgogerly. Thanks for taking this on! Is your overall intent with this PR to move capabilities currently in the Lambda Plugin natively into OSS so we can deprecate the plugin?

Is there anything in the plugin that you are not planning on replacing?

Do you think additional related PRs will need to be created in addition to this one?

@mattgogerly
Copy link
Member Author

Hey @mattgogerly. Thanks for taking this on! Is your overall intent with this PR to move capabilities currently in the Lambda Plugin natively into OSS so we can deprecate the plugin?

Is there anything in the plugin that you are not planning on replacing?

Do you think additional related PRs will need to be created in addition to this one?

The plugin code was moved into Orca in #4449.

This PR rewrites that code to use Kato/Oort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants