test(deploymentmonitor): Add Test Case for EvaluateDeploymentTask

This commit introduces a test case aimed at demonstrating the existing behaviour of the ‘EvaluateDeploymentTask’ task. The primary objective of this test case is to verify the proper handling of ‘RetrofitError’ thrown by the retrofit client when interacting with DeploymentMonitorService APIs.

Details:
- Added a dedicated test case to assess the behaviour of ‘EvaluateDeploymentTask’.
- The test case specifically focuses on handling ‘RetrofitError’ instances thrown by DeploymentMonitorService APIs.
- This step is essential for understanding and validating the current behaviour of the task in response to potential errors during API interactions.

This test case serves as a baseline for future modifications and enhancements related to the ‘EvaluateDeploymentTask’.

orca-clouddriver/src/test/groovy/com/netflix/spinnaker/orca/clouddriver/tasks/monitoreddeploy/EvaluateDeploymentHealthTaskSpec.groovy

@@ -16,18 +16,23 @@
 
 package com.netflix.spinnaker.orca.clouddriver.tasks.monitoreddeploy
 
+import com.fasterxml.jackson.databind.ObjectMapper
 import com.netflix.spectator.api.NoopRegistry
 import com.netflix.spinnaker.config.DeploymentMonitorDefinition
 import com.netflix.spinnaker.orca.api.pipeline.models.ExecutionStatus
 import com.netflix.spinnaker.orca.api.pipeline.TaskResult
+import com.netflix.spinnaker.orca.clouddriver.MortServiceSpec
 import com.netflix.spinnaker.orca.deploymentmonitor.DeploymentMonitorService
 import com.netflix.spinnaker.orca.deploymentmonitor.models.DeploymentMonitorStageConfig
 import com.netflix.spinnaker.orca.deploymentmonitor.models.DeploymentStep
 import com.netflix.spinnaker.orca.deploymentmonitor.models.EvaluateHealthResponse
 import com.netflix.spinnaker.orca.deploymentmonitor.models.MonitoredDeployInternalStageData
 import com.netflix.spinnaker.orca.pipeline.model.PipelineExecutionImpl
 import com.netflix.spinnaker.orca.pipeline.model.StageExecutionImpl
+import org.springframework.http.HttpStatus
 import retrofit.RetrofitError
+import retrofit.client.Response
+import retrofit.converter.JacksonConverter
 import spock.lang.Specification
 import com.netflix.spinnaker.orca.deploymentmonitor.DeploymentMonitorServiceProvider
 import spock.lang.Unroll
@@ -198,6 +203,50 @@ class EvaluateDeploymentHealthTaskSpec extends Specification {
  false | null || ExecutionStatus.FAILED_CONTINUE
  }
 
+ def "should return status as RUNNING when Retrofit http error is thrown"() {
+
+ def converter = new JacksonConverter(new ObjectMapper())
+
+ Response response =
+ new Response(
+ "/deployment/evaluateHealth",
+ HttpStatus.BAD_REQUEST.value(),
+ "bad-request",
+ Collections.emptyList(),
+ new MortServiceSpec.MockTypedInput(converter, [
+ accountName: "account",
+ description: "simple description",
+ name: "sg1",
+ region: "region",
+ type: "openstack"
+ ]))
+
+ given:
+ def monitorServiceStub = Stub(DeploymentMonitorService) {
+ evaluateHealth(_) >> {
+ throw RetrofitError.httpError("https://foo.com/deployment/evaluateHealth", response, converter, null)
+ }
+ }
+
+ def serviceProviderStub = getServiceProviderStub(monitorServiceStub)
+
+ def task = new EvaluateDeploymentHealthTask(serviceProviderStub, new NoopRegistry())
+
+ MonitoredDeployInternalStageData stageData = new MonitoredDeployInternalStageData()
+ stageData.deploymentMonitor = new DeploymentMonitorStageConfig()
+ stageData.deploymentMonitor.id = "LogMonitorId"
+
+ def stage = new StageExecutionImpl(pipe, "evaluateDeploymentHealth", stageData.toContextMap() + [application: pipe.application])
+ stage.startTime = Instant.now().toEpochMilli()
+
+ when: 'we can still retry'
+ TaskResult result = task.execute(stage)
+
+ then: 'should retry'
+ result.status == ExecutionStatus.RUNNING
+ result.context.deployMonitorHttpRetryCount == 1
+ }
+
  private getServiceProviderStub(monitorServiceStub) {
  return getServiceProviderStub(monitorServiceStub, {})
  }