Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gce): upgrade google-api-client to 1.33.0 #1205

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Conversation

edgarulg
Copy link
Contributor

Upgrade google api client to 1.33.0 to allow new features in GCE.

All the google api services were updated to the compatible version with 1.33.0

@jasonmcintosh
Copy link
Member

Time to do some bumps... clouddriver & halyard post this please!

@jasonmcintosh
Copy link
Member

ALSO: we JUST had that other bump, did we miss something? https://github.com/spinnaker/kork/pull/1203/files this one

@edgarulg
Copy link
Contributor Author

ALSO: we JUST had that other bump, did we miss something? https://github.com/spinnaker/kork/pull/1203/files this one

yes, I upgraded the client to 1.31.5 but the field I want to include from GCE is still not present in that version. So I had to upgrade until 1.33.x in this new PR :(

The versions of google-api-service-* are weird. They have the wrong client version in their name. Here is an example: https://mvnrepository.com/artifact/com.google.apis/google-api-services-compute/beta-rev20211228-1.32.1
The versions says that the api-client is 1.32.1 but if you check the dependencies in maven it actually depends on 1.33.0

All the upgrades I did says 1.32.1 but that is not true. Everything is pointing to api-client 1.33.x

@edgarulg
Copy link
Contributor Author

The only breaking changed that I saw on the upgrade is the deprecation of JacksonFactory. We use JacksonFactory in kork / clouddriver (they might be more services) but we use it to generate a default instance that extends of JsonFactory.

In the newer versions we only had GsonFactory but as it also extends from JsonFactory. We can replace JacksonFactorytoGsonFactory` and in theory we shouldn't have issues.

Copy link
Member

@jasonmcintosh jasonmcintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tied to other PR work.

@jasonmcintosh jasonmcintosh added the ready to merge Approved and ready for merge label Sep 26, 2024
@mergify mergify bot added the auto merged label Sep 26, 2024
@mergify mergify bot merged commit 9960290 into master Sep 26, 2024
7 checks passed
@edgarulg
Copy link
Contributor Author

Clouddriver PR: spinnaker/clouddriver#6282

@edgarulg
Copy link
Contributor Author

I will bump this change into Harlyard and will share the PR as well

@edgarulg
Copy link
Contributor Author

I tagged kork and all the autobumps were created. The following services had build issue regarding the google upgrade and I pushed the fix for all of them.
spinnaker/clouddriver#6286
spinnaker/fiat#1180
spinnaker/igor#1278
spinnaker/halyard#2186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants