-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gce): upgrade google-api-client to 1.33.0 #1205
Conversation
Time to do some bumps... clouddriver & halyard post this please! |
ALSO: we JUST had that other bump, did we miss something? https://github.com/spinnaker/kork/pull/1203/files this one |
yes, I upgraded the client to 1.31.5 but the field I want to include from GCE is still not present in that version. So I had to upgrade until 1.33.x in this new PR :( The versions of google-api-service-* are weird. They have the wrong client version in their name. Here is an example: https://mvnrepository.com/artifact/com.google.apis/google-api-services-compute/beta-rev20211228-1.32.1 All the upgrades I did says 1.32.1 but that is not true. Everything is pointing to api-client 1.33.x |
The only breaking changed that I saw on the upgrade is the deprecation of In the newer versions we only had |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tied to other PR work.
Clouddriver PR: spinnaker/clouddriver#6282 |
I will bump this change into Harlyard and will share the PR as well |
I tagged kork and all the autobumps were created. The following services had build issue regarding the google upgrade and I pushed the fix for all of them. |
Upgrade google api client to 1.33.0 to allow new features in GCE.
All the google api services were updated to the compatible version with 1.33.0