feature(retrofit): Add exception handler to service factory #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
spinnaker/gate#1842 is the corresponding gate PR. |
|
@Mergifyio update |
❌ Mergify doesn't have permission to updateFor security reasons, Mergify can't update this pull request. Try updating locally. |
This commit adds the SpinnakerRetrofitErrorHandler to service factories which allows for clients that rely on service factories to properly have RetrofitErrors be converted to some Spinnaker*Exception. Signed-off-by: benjamin-j-powell <[email protected]>
dbyron-sf
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the SpinnakerRetrofitErrorHandler to service factories which allows for clients that rely on service factories to properly have RetrofitErrors be converted to some Spinnaker*Exception.
This PR needs to remain as a draft until gate has fully changed its exception handling to support non-RetrofitError exceptions