chore(test): Add HikariConfig to initDatabase util used for testing. #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, is this a feature, or a chore? What's the motivation? |
armory-abedonik
force-pushed
the
BOB-31035
branch
from
635632e
to
2734ab1
Compare
armory-abedonik
changed the title
We need to use MaximumPoolSize=10 to fix failed tests in this PR: |
dbyron-sf
approved these changes
Apr 14, 2023
jasonmcintosh
approved these changes
Apr 14, 2023
richard-timpson
pushed a commit
to richard-timpson/kork
that referenced
this pull request
May 3, 2023
…pinnaker#1045) (spinnaker#81) @W-12647090 Co-authored-by: armory-abedonik <[email protected]>
droustchev-pd
pushed a commit
to droustchev-pd/kork
that referenced
this pull request
May 11, 2023
mergify bot
added a commit
that referenced
this pull request
Jun 13, 2023
* Bump okhttp3 to version 4.9.3 This is the last 4.x version before upgrading to Kotlin 1.60.20 and I did not want to conflate too many changes at once. * Use extension functions See: https://square.github.io/okhttp/changelogs/upgrading_to_okhttp_4/#extension-functions * Use properties See: https://square.github.io/okhttp/changelogs/upgrading_to_okhttp_4/#vars-and-vals * chore(test): Add HikariConfig to initDatabase util used for testing. (#1045) * Update tests to use extension functions --------- Co-authored-by: armory-abedonik <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.