Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE:2021-0341 upgrading package from retrofit retrofit2 #1000

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Luthan95
Copy link
Contributor

@Luthan95 Luthan95 commented Dec 6, 2022

here is the reference that i used.
square/retrofit#1299

for logging interceptor
https://howtodoinjava.com/retrofit2/logging-with-retrofit2/

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

  • 4311e62: changing from retrofit to retrofit2 package as retrofit package is outdated

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.


@ConfigurationProperties("retrofit")
@ConfigurationProperties("retrofit2")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to break existing configuration. Can we leave it as retrofit?

@dbyron-sf dbyron-sf marked this pull request as draft December 6, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants