fix(artifactStore): Make applicationsRegex pattern matching case-inse…

…nsitive (#1206)
spinnaker · Sep 26, 2024 · ec51820 · ec51820
1 parent 2f38092
commit ec51820
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/...ain/java/com/netflix/spinnaker/kork/artifacts/artifactstore/s3/S3ArtifactStoreStorer.java b/...ain/java/com/netflix/spinnaker/kork/artifacts/artifactstore/s3/S3ArtifactStoreStorer.java
@@ -59,7 +59,9 @@ public S3ArtifactStoreStorer(
     this.bucket = bucket;
     this.uriBuilder = uriBuilder;
     this.applicationsPattern =
-        (applicationsRegex != null) ? Pattern.compile(applicationsRegex) : null;
+        (applicationsRegex != null)
+            ? Pattern.compile(applicationsRegex, Pattern.CASE_INSENSITIVE)
+            : null;
   }
 
   /**

diff --git a/...java/com/netflix/spinnaker/kork/artifacts/artifactstore/s3/S3ArtifactStoreStorerTest.java b/...java/com/netflix/spinnaker/kork/artifacts/artifactstore/s3/S3ArtifactStoreStorerTest.java
@@ -99,6 +99,8 @@ private static Stream<Arguments> applicationsRegexArgs() {
         Arguments.of("any", null, true),
         Arguments.of("app-one", allowRegex, true),
         Arguments.of("app-four", allowRegex, false),
+        Arguments.of("APP-One", allowRegex, true),
+        Arguments.of("APP-FOUR", allowRegex, false),
         Arguments.of("one", allowRegex, false),
         Arguments.of("app-one-more", allowRegex, false),
         Arguments.of("app-five", allowRegex, true),