Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dependencies): Autobump korkVersion #2029

Merged
merged 1 commit into from Apr 2, 2024
Merged

chore(dependencies): Autobump korkVersion #2029

merged 1 commit into from Apr 2, 2024

Conversation

spinnakerbot
Copy link
Contributor

No description provided.

@mergify mergify bot requested a review from a team April 21, 2022 00:09
@dbyron-sf
Copy link
Contributor

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Apr 21, 2022

update

✅ Branch has been successfully updated

@dbyron-sf
Copy link
Contributor

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Apr 21, 2022

update

✅ Branch has been successfully updated

@nabuskey
Copy link
Contributor

From what I have investigated, there are two issues:

  1. Docker repository reference is now invalid. It is currently set to use the testcontainer images from a public ECR repository but it seems to not work anymore. I think we can updated it to either point to another ECR or point to Dockerhub.
  2. Spring tests takes a lot of time when ran together. If they are run individually, they work as expected. It seems it is related to DB connection handling during Spring bean refresh in between tests. I haven't had the time to really dig into this part.

@spinnakerbot spinnakerbot force-pushed the autobump-korkVersion-master branch 2 times, most recently from 63bed15 to 1a29604 Compare July 27, 2022 23:19
@spinnakerbot spinnakerbot force-pushed the autobump-korkVersion-master branch 2 times, most recently from c44e667 to 3bbcfca Compare October 3, 2022 15:28
@spinnakerbot spinnakerbot force-pushed the autobump-korkVersion-master branch 3 times, most recently from cca96f3 to 5bfaa60 Compare November 24, 2022 15:48
@spinnakerbot spinnakerbot force-pushed the autobump-korkVersion-master branch 5 times, most recently from 3bd2b1b to 8de58da Compare December 15, 2022 16:45
@spinnakerbot spinnakerbot force-pushed the autobump-korkVersion-master branch 2 times, most recently from 48e61c5 to 6e4fc74 Compare January 30, 2023 15:22
@spinnakerbot spinnakerbot force-pushed the autobump-korkVersion-master branch 3 times, most recently from f3ba9a6 to 4fb912a Compare November 14, 2023 21:21
@spinnakerbot spinnakerbot force-pushed the autobump-korkVersion-master branch 4 times, most recently from 47b2612 to 87d32b0 Compare November 21, 2023 23:56
@spinnakerbot spinnakerbot force-pushed the autobump-korkVersion-master branch 3 times, most recently from a3631c4 to b960592 Compare January 5, 2024 23:34
@spinnakerbot spinnakerbot force-pushed the autobump-korkVersion-master branch 3 times, most recently from 5ff32a8 to af7d338 Compare February 7, 2024 19:06
@spinnakerbot spinnakerbot force-pushed the autobump-korkVersion-master branch 4 times, most recently from 249bfbb to c826e42 Compare February 23, 2024 17:38
@spinnakerbot spinnakerbot force-pushed the autobump-korkVersion-master branch 2 times, most recently from ca1860b to d62a86d Compare March 3, 2024 17:34
@spinnakerbot spinnakerbot force-pushed the autobump-korkVersion-master branch 2 times, most recently from ee0dba5 to 097f428 Compare March 12, 2024 17:27
@mergify mergify bot added the auto merged label Apr 2, 2024
@mergify mergify bot merged commit 72cb9c6 into spinnaker:master Apr 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto merged autobump-korkVersion-master target-release/1.31
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@spinnakerbot @dbyron-sf @nabuskey