refactor(igor): Rename master to controller #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change renames master to controller. The reasoning behind this change is that none of the services seems to be using that terminology anymore. Changing the terminology in Igor to something that at least some of the services uses makes it easier to understand what's being referenced. All externally accessible APIs with the old terminology are marked as deprecated and will use the new functions until the deprecated functions are finally removed. This to remain backward compatible.
Z-byte-prog
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change renames master to controller. The reasoning behind this
change is that none of the services seems to be using that terminology
anymore.
Changing the terminology in Igor to something that at least some of
the services uses makes it easier to understand what's being referenced.
All externally accessible APIs with the old terminology are marked as
deprecated and will use the new functions until the deprecated functions
are finally removed. This to remain backward compatible.