fix(travis): Properly return API triggered builds (#1256)

When populating the build dropdown for manual executions, manually triggered builds are missing for Travis Enterprise version 3.0.54 and newer. Before these builds had the same `event_type=push` as other builds, but now they have `event_type=api`. Adding `api` to the filtering fixes the issue.
spinnaker · May 8, 2024 · 73354d5 · 73354d5
1 parent ff4019b
commit 73354d5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/...monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/service/TravisService.java b/...monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/service/TravisService.java
@@ -266,7 +266,7 @@ public List<GenericBuild> getBuilds(String inputRepoSlug) {
  getAccessToken(),
  repoSlug,
  branch,
- "push",
+ "push,api",
  buildResultLimit,
  addLogCompleteIfApplicable());
  break;

diff --git a/...travis/src/test/groovy/com/netflix/spinnaker/igor/travis/service/TravisServiceSpec.groovy b/...travis/src/test/groovy/com/netflix/spinnaker/igor/travis/service/TravisServiceSpec.groovy
@@ -351,10 +351,10 @@ class TravisServiceSpec extends Specification {
  service.accessToken = accessToken
 
  when:
- def genericBuilds = service.getBuilds("my/slug")
+ def genericBuilds = service.getBuilds("my/slug/master")
 
  then:
- 1 * client.v3builds("token someToken", "my/slug", TRAVIS_BUILD_RESULT_LIMIT,
+ 1 * client.v3builds("token someToken", "my/slug", "master", "push,api", TRAVIS_BUILD_RESULT_LIMIT,
  legacyLogFetching ? null : "build.log_complete") >> new V3Builds([builds: [build]])
  (isLogCompleteFlag ? 0 : 1) * travisCache.getJobLog("travis-ci", 2) >> (isLogCached ? "log" : null)
  (!isLogCompleteFlag && !isLogCached ? 1 : 0) * client.jobLog("token someToken", 2) >> v3log