Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(redblack): fixing redblack onchange values #10107

Merged
merged 5 commits into from May 13, 2024

Conversation

shlomodaari
Copy link
Contributor

@shlomodaari shlomodaari commented May 10, 2024

This should fix this issue when values are not responding when using red/black strategy

@shlomodaari
Copy link
Contributor Author

Screen.Recording.2024-05-10.at.4.03.59.PM.mov

@mattgogerly
Copy link
Member

Thanks for the contribution! Mind cleaning up the linting errors so we can get this merged?

Copy link
Contributor

@ovidiupopa07 ovidiupopa07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution. LGTM

@ovidiupopa07 ovidiupopa07 added the ready to merge Reviewed and ready for merge label May 13, 2024
@mergify mergify bot added the auto merged Merged automatically by a bot label May 13, 2024
@mergify mergify bot merged commit 443408e into spinnaker:master May 13, 2024
4 checks passed
@jasonmcintosh
Copy link
Member

@Mergifyio backport release-1.34.x release-1.33.x release-1.32.x

Copy link
Contributor

mergify bot commented May 13, 2024

backport release-1.34.x release-1.33.x release-1.32.x

✅ Backports have been created

@jasonmcintosh
Copy link
Member

@Mergifyio backport release-1.28.x

Copy link
Contributor

mergify bot commented May 13, 2024

backport release-1.28.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 13, 2024
* fix(redblack): fixing redblack onchange values

* fix(lint): fixing linting erros

* fix(lint): fixing linting - lodash

* fix(prettier): fixing prettier for AdditionalFields.tsx

---------

Co-authored-by: ovidiupopa07 <[email protected]>
(cherry picked from commit 443408e)
mergify bot pushed a commit that referenced this pull request May 13, 2024
* fix(redblack): fixing redblack onchange values

* fix(lint): fixing linting erros

* fix(lint): fixing linting - lodash

* fix(prettier): fixing prettier for AdditionalFields.tsx

---------

Co-authored-by: ovidiupopa07 <[email protected]>
(cherry picked from commit 443408e)
mergify bot pushed a commit that referenced this pull request May 13, 2024
* fix(redblack): fixing redblack onchange values

* fix(lint): fixing linting erros

* fix(lint): fixing linting - lodash

* fix(prettier): fixing prettier for AdditionalFields.tsx

---------

Co-authored-by: ovidiupopa07 <[email protected]>
(cherry picked from commit 443408e)
mergify bot pushed a commit that referenced this pull request May 13, 2024
* fix(redblack): fixing redblack onchange values

* fix(lint): fixing linting erros

* fix(lint): fixing linting - lodash

* fix(prettier): fixing prettier for AdditionalFields.tsx

---------

Co-authored-by: ovidiupopa07 <[email protected]>
(cherry picked from commit 443408e)
mergify bot added a commit that referenced this pull request May 13, 2024
* fix(redblack): fixing redblack onchange values

* fix(lint): fixing linting erros

* fix(lint): fixing linting - lodash

* fix(prettier): fixing prettier for AdditionalFields.tsx

---------

Co-authored-by: ovidiupopa07 <[email protected]>
(cherry picked from commit 443408e)

Co-authored-by: Shlomo Daari <[email protected]>
mergify bot added a commit that referenced this pull request May 13, 2024
* fix(redblack): fixing redblack onchange values

* fix(lint): fixing linting erros

* fix(lint): fixing linting - lodash

* fix(prettier): fixing prettier for AdditionalFields.tsx

---------

Co-authored-by: ovidiupopa07 <[email protected]>
(cherry picked from commit 443408e)

Co-authored-by: Shlomo Daari <[email protected]>
mergify bot added a commit that referenced this pull request May 13, 2024
* fix(redblack): fixing redblack onchange values

* fix(lint): fixing linting erros

* fix(lint): fixing linting - lodash

* fix(prettier): fixing prettier for AdditionalFields.tsx

---------

Co-authored-by: ovidiupopa07 <[email protected]>
(cherry picked from commit 443408e)

Co-authored-by: Shlomo Daari <[email protected]>
mergify bot added a commit that referenced this pull request May 13, 2024
* fix(redblack): fixing redblack onchange values

* fix(lint): fixing linting erros

* fix(lint): fixing linting - lodash

* fix(prettier): fixing prettier for AdditionalFields.tsx

---------

Co-authored-by: ovidiupopa07 <[email protected]>
(cherry picked from commit 443408e)

Co-authored-by: Shlomo Daari <[email protected]>
@idiamant
Copy link

@shlomodaari Thank you very much for the fix!

Appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Reviewed and ready for merge target-release/1.35
Projects
None yet
6 participants