Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ecs): refactor applicationCachingAgent to use unique namespace #5375

Merged
merged 3 commits into from
Jun 1, 2021
Merged

fix(ecs): refactor applicationCachingAgent to use unique namespace #5375

merged 3 commits into from
Jun 1, 2021

Conversation

piradeepk
Copy link
Contributor

@piradeepk piradeepk commented Jun 1, 2021 •
edited

This change updates the application caching agent to use a new namespace ECS_APPLICATIONS rather than reusing the existing APPLICATIONS namespace.

Verified:

  1. ECS provider deployments still work
  2. ApplicationCachingAgent is continuing to log messages

Fixes: spinnaker/spinnaker#6084

@piradeepk piradeepk requested a review from allisaurus June 1, 2021 14:02
@piradeepk
Copy link
Contributor Author

@deverton for your awareness. This will be the first of 2 PRs that need to be merged in that should resolve your issue.

allisaurus
allisaurus approved these changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@allisaurus allisaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@piradeepk piradeepk added the ready to merge Approved and ready for a merge label Jun 1, 2021
@mergify mergify bot added the auto merged Merged automatically by a bot label Jun 1, 2021
@mergify mergify bot merged commit 417c337 into spinnaker:master Jun 1, 2021
@allisaurus allisaurus added the backport-candidate Add to PRs to designate release branch patch candidates. label Jun 4, 2021
@deverton deverton mentioned this pull request Jun 7, 2021
Open
@link108
Copy link
Member

link108 commented Jun 9, 2021

@Mergifyio backport release-1.26.x

@mergify mergify bot mentioned this pull request Jun 9, 2021
Merged
mergify bot pushed a commit that referenced this pull request Jun 9, 2021
@piradeepk
fix(ecs): refactor applicationCachingAgent to use unique namespace (#…
c5637bf 
…5375)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 417c337)
@mergify
Copy link
Contributor

mergify bot commented Jun 9, 2021

Command backport release-1.26.x: success

Backports have been created

link108 pushed a commit that referenced this pull request Jun 9, 2021
@mergify @piradeepk
fix(ecs): refactor applicationCachingAgent to use unique namespace (b…
e261cfc 
…ackport #5375) (#5384)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 417c337)

Co-authored-by: Piradeep Kandasamy <[email protected]>
@link108 link108 removed the backport-candidate Add to PRs to designate release branch patch candidates. label Jun 9, 2021
@allisaurus allisaurus mentioned this pull request Jun 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allisaurus allisaurus allisaurus approved these changes

Assignees

@allisaurus allisaurus

Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for a merge target-release/1.27
Projects
None yet
Milestone
No milestone
4 participants
@piradeepk @link108 @allisaurus @spinnakerbot