Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .gitignore and doc strings #2

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Conversation

SMesser
Copy link

@SMesser SMesser commented Jul 18, 2016

No description provided.

@@ -0,0 +1,6 @@
db.sqlite3
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these (long overdue) changes! One thing I'm not sure about is whether it's necessary to include sqlite in the gitignore. Most people who've taken this tutorial aren't experienced with databases, and I'm hoping to use as few unfamiliar terms as possible.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that's a good point. I had added db.sqlite3 here (and to my local copy of the other git project I generated during the Djangocon tutorials) because I was adding Django locally and that's its default database. Your project isn't using Django or a DB as such, so there's not much point in having it in the .gitignore. I'll remove it and push a change in a bit.

Sarah Messer added 22 commits July 18, 2016 12:01
Remove dependency on Django_extensions.
…ns. Add seed_data. Replace tests with very basic ones suitable to this project.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants