Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce egress gateway agent event #1632

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Reduce egress gateway agent event #1632

merged 1 commit into from
Feb 27, 2025

Conversation

lou-lan
Copy link
Collaborator

@lou-lan lou-lan commented Feb 18, 2025

This PR removes an unnecessary watch event, significantly reducing log output.

Fix #1491

@lou-lan lou-lan requested a review from weizhoublue as a code owner February 18, 2025 15:43
@lou-lan lou-lan added the release/none should not recoded in new release label Feb 18, 2025
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.79%. Comparing base (8c21c80) to head (3f083b9).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1632      +/-   ##
==========================================
+ Coverage   81.71%   81.79%   +0.07%     
==========================================
  Files          19       19              
  Lines        2806     2807       +1     
==========================================
+ Hits         2293     2296       +3     
+ Misses        401      399       -2     
  Partials      112      112              
Flag Coverage Δ
unittests 81.79% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/config/config.go 85.12% <100.00%> (+0.12%) ⬆️
pkg/controller/endpoint/endpoint_slice.go 98.24% <ø> (ø)

... and 1 file with indirect coverage changes

weizhoublue
weizhoublue previously approved these changes Feb 19, 2025
@weizhoublue weizhoublue added release/bug bug pr recoded in new release and removed release/none should not recoded in new release labels Feb 19, 2025
@weizhoublue weizhoublue self-requested a review February 19, 2025 01:44
@weizhoublue
Copy link
Collaborator

@lou-lan handle the conflict

@weizhoublue weizhoublue merged commit 9549efe into main Feb 27, 2025
35 checks passed
@weizhoublue weizhoublue deleted the reduce-event branch February 27, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/bug bug pr recoded in new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature? change log level
2 participants