Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versionremoved to admonitions #163

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stevepiercy
Copy link
Contributor

@stevepiercy
Copy link
Contributor Author

I don't think adding this feature will break anything, but it might not render as expected on sites that use Sphinx<7.3.

@stevepiercy
Copy link
Contributor Author

I'm not sure why the CI build failed. Can I get an assist?

stevepiercy added a commit to stevepiercy/pydata-sphinx-theme that referenced this pull request Dec 20, 2024
Note that I added a snippet in the Kitchen Sink to preview the change. I have an open PR in sphinx-themes/sphinx-themes.org#163 to add it upstream. I can remove this snippet, if you prefer, or you can clobber it the next time you run a sync.

I'll also attach a screenshot.

- Closes pydata#2086
drammock added a commit to pydata/pydata-sphinx-theme that referenced this pull request Jan 24, 2025
Note that I added a snippet in the Kitchen Sink to preview the change. I
have an open PR in
sphinx-themes/sphinx-themes.org#163 to add it
upstream. I can remove this snippet, if you prefer, or you can clobber
it the next time you run a sync.

![Screenshot 2024-12-20 at 3 38 59
AM](https://github.com/user-attachments/assets/8bec8c56-ca63-44b2-8d34-e5988ba69bce)

![Screenshot 2024-12-20 at 3 40 17
AM](https://github.com/user-attachments/assets/bb1a93da-28c4-4152-be28-34f1eea9d98e)

- Closes #2086

---------

Co-authored-by: Daniel McCloy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant