Fix #2835: Trigger rebuild when theme files change#14421
Open
kishorhange111 wants to merge 3 commits intosphinx-doc:masterfrom
Open
Fix #2835: Trigger rebuild when theme files change#14421kishorhange111 wants to merge 3 commits intosphinx-doc:masterfrom
kishorhange111 wants to merge 3 commits intosphinx-doc:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where changes to theme files (templates and static assets) were not detected by Sphinx, requiring a manual
make cleanbefore rebuilding.The change introduces a
theme_hashinBuildInfoto track theme file changes. When the hash differs from the previous build, Sphinx detects the mismatch and triggers a rebuild automatically.Tests have been added to verify that theme changes correctly trigger rebuilds.
I have also tested this locally by modifying theme files and rebuilding without running
make clean. Sphinx correctly detected the changes and triggered a rebuild, confirming the expected behavior.Please let me know if any further adjustments would be helpful.
References