Accept path-like configuration options #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For various configuration options, sanity checks for path-related options would require values to be string values. If a user defined these values using PathLib, a configuration exception would be thrown (and a user would have to workaround by explicitly str-casting the values). To be flexible for these configurations, ensure all path-related options can accept both `str` or `os.PathLike` typed entries. Signed-off-by: James Knight <[email protected]>
A series of configuration options prepared with pathlib and passed into configuration checks (and more) had to be str-casted to ensure the checks would not trigger an unexpected error. Since support has been added into this extension to accept both str and path-like types, removing the unnecessary casting. Signed-off-by: James Knight <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For various configuration options, sanity checks for path-related options would require values to be string values. If a user defined these values using PathLib, a configuration exception would be thrown (and a user would have to workaround by explicitly str-casting the values). To be flexible for these configurations, ensure all path-related options can accept both
stroros.PathLiketyped entries.