lnpeer: async maybe_send_commitment
#7836
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this builds on top of #7835 (first commit is from there)
This is re cc1b4a5#commitcomment-74922012
We
await self.ping_if_required()
insidemaybe_send_commitment()
.This needed making
maybe_send_commitment
async, which really quite snowballed o.OAnyway, this is a separate PR from #7835, as that PR is useful in itself.