Convert2cc #7700
Convert2cc #7700
Conversation
…show why convert2cc is not possible
…onvert2cc till https://github.com/Coldcard/ckcc-protocol/pull/17/files gets resolved; logging
|
| @@ -593,15 +594,16 @@ def on_cb(x): | |||
| if cb_checked: | |||
| self.config.set_key('dont_show_testnet_warning', True) | |||
|
|
|||
| def open_wallet(self): | |||
| def open_wallet(self, filename=None): | |||
There was a problem hiding this comment.
add ability to skip getOpenFileName dialog if filename is provided
| btn_close = CloseButton(dialog) | ||
| btns = Buttons(btn_export_info, btn_close) | ||
| vbox.addLayout(btns) |
There was a problem hiding this comment.
similar to https://github.com/spesmilo/electrum/pull/7682/files where we need an ability to add multiple buttons to wallet information dialog
| vbox.addLayout(btns) | ||
| if wallet_info_btns: | ||
| # now more than one wallet_info_butons hook, needs concat | ||
| wallet_info_btns = reduce(operator.concat, wallet_info_btns) |
There was a problem hiding this comment.
now we also expect more than one hook to provide data
| @@ -232,6 +232,8 @@ def run_hook(name, *args): | |||
| results.append(r) | |||
|
|
|||
| if results: | |||
| if name == "wallet_info_buttons": | |||
There was a problem hiding this comment.
not sure If I understand this constraint - why can only one result from hook be accepted? Here I expect more than one hook to provide data
electrum/plugins/convert2cc/qt.py
Outdated
| if selected_index is not None: | ||
| target_keystore = keystores[selected_index] | ||
| with self.coldcards_connected() as connected_cc_clients: | ||
| # dev = self.match_candidate_keystore_to_connected_cc_device(connected_cc_clients, target_keystore) |
There was a problem hiding this comment.
for now - not sending device to convert2cc - it is not needed and in current ckcc-protocol version it causes huge slowdown, see Coldcard/ckcc-protocol#17
… by other app or electrum itself)
…plugged in coldcards that canont be open; change dialog closing logic
|
added msg of coldcard device which we cannot connect to but is plugged in (other application using it) if coldcard is opened in electrum a we can find it in device_manager.clients that connection to device will be used... also check #7701)
|
|
instead of warning for encrypted wallets - I found and easy way to preserve encryption settings. User can choose to preserve them or not (checkbox) hardware device encryption: password encryption: If one chooses to preserve encryption settings, same pwd (pubkey) will be used for encryption. If one chooses NOT to preserve, newly generated wallet is plaintext and can be encrypted later via standard path (wallet -> password ...) |
electrum/plugins/convert2cc/qt.py
Outdated
| where one chooses which hardware device gets converted to Coldcard.<br> | ||
| All wallet data like contacts, labels, payment requests etc. are preserved.<br> | ||
| If you've chosen to change your hardware wallet to Coldcard, convert2cc<br> | ||
| will save you the hustle.</p> |
|
Do I understand it correctly that the whole purpose of this plugin is to help users who have non-coldcard hw devices and want to migrate to coldcard? -- and this plugin creates a new wallet file which is sort of a copy of the existing one, except one of the keystores is replaced with Coldcard_KeyStore? |
|
yes and yes, yet it's more of the implementation what you've described, purpose is to preserve all wallet "metadata" like labels, payment requests, contacts etc. and only change hww device |
… master already has needed changes - witing for pypy); typo fix
Testing:
(can be done even without Coldcard connected, it won't give you a hint based on master fingerprint match)
if your coldcard is not connected there will be no match